Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues with scan next/prev #39

Closed
jbfaden opened this issue Nov 10, 2022 · 7 comments
Closed

issues with scan next/prev #39

jbfaden opened this issue Nov 10, 2022 · 7 comments

Comments

@jbfaden
Copy link
Member

jbfaden commented Nov 10, 2022

The DasAxis should provide a "scan next" button when the "step next" action would advance to a frame with no data. This feature has a few problems:

  • "scan" action doesn't show initially, must step first
  • scanning to the next frame steps an integer number of times, when it would be more appropriate to recenter.
  • sometimes the "scan" or "step" button doesn't appear, though clicking there would take the action.
jbfaden added a commit that referenced this issue Nov 10, 2022
@jbfaden
scan next #39 now
2247035 
recenters on the data.
@jbfaden
Copy link
Member Author

jbfaden commented Nov 10, 2022

scanning to the next frame recenters now.

@cpiker
Copy link
Member

cpiker commented Nov 11, 2022

How do you decide how far to scan?

@jbfaden
Copy link
Member Author

jbfaden commented Nov 11, 2022

It must have the data in memory, which is a place where things could be improved. So it uses the paradigm that the scientist loads all the data, then zooms in to the first interval, and scans from there. I'm not sure how it would be improved to load more data, since it would have to be aware of the source of the data, which it is not.

@jbfaden
Copy link
Member Author

jbfaden commented Nov 11, 2022

Actually, it's Autoplot which adds the "scan" action, I was letting Netbeans find things for me and didn't notice this is actually not a Das2 thing. So it could probably be much smarter, allowing scans outside of the loaded data.

@jbfaden
Copy link
Member Author

jbfaden commented Nov 11, 2022

See also https://sourceforge.net/p/autoplot/bugs/1209/ a related bug in the Autoplot bug tracker.

jbfaden added a commit that referenced this issue Nov 11, 2022
@jbfaden
#39: getPreviousInterval
97d40cd 
and getNextInterval logic would miss the first interval when the range
was slightly outside of the dataset range.
jbfaden added a commit that referenced this issue Nov 11, 2022
@jbfaden
#39: rename the private
3ec0edc 
scanNext and scanPrevious buttons stepNext and stepPrevious, since 
these were relabelled and Autoplot registers a "scan" action.
jbfaden added a commit that referenced this issue Nov 11, 2022
@jbfaden
#39: experiment with
7624b6b 
recentering, which should not be done when it's not terribly productive.
jbfaden added a commit that referenced this issue Nov 12, 2022
@jbfaden
#39: experiment with
10dfa2b 
recentering, which should not be done when it's not terribly productive.
@jbfaden
Copy link
Member Author

jbfaden commented Sep 26, 2024

I found a nice case to study this, but since it's an Autoplot bug, I'll describe the case there and close this ticket. (https://sourceforge.net/p/autoplot/bugs/1209/)

@jbfaden jbfaden closed this as completed Sep 26, 2024
@jbfaden
Copy link
Member Author

jbfaden commented Sep 26, 2024

Actually this is the Autoplot ticket: https://sourceforge.net/p/autoplot/bugs/1359/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbfaden @cpiker