Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

das2stream misformat around time with zero milliseconds #16

Open
jbfaden opened this issue Jun 21, 2021 · 1 comment
Open

das2stream misformat around time with zero milliseconds #16

jbfaden opened this issue Jun 21, 2021 · 1 comment

Comments

@jbfaden
Copy link
Member

jbfaden commented Jun 21, 2021

Sadie showed where a das2stream could be produced containing times like "2017-11-27T12:20:12.-00". This is when the milliseconds are nearly 0. To demo the bug:

  • plot vap+cdaweb:ds=RBSPA_EFW-L2_FBK&filter=filterba&id=fbk7_scmw_pk_lowoverlay&timerange=2017-11-28
  • zoom in to 2017-11-28 11:48:40 to 11:49:20
  • horizontal interval average (which does sum over frequency)
  • right-click on the DasPlot and "dump data to file"
  • grep for "-00" in the output.
jbfaden added a commit that referenced this issue Jun 21, 2021
@jbfaden
#16: check for this
47020dc 
condition where rounding leads to -1 in 7th field.  Really all this old
code needs to be re-written.
@jbfaden
Copy link
Member Author

jbfaden commented Jun 22, 2021

The solution here is to check for -1 where the rounding takes it down a microsecond, and call it zero. The code still has awkward floating-point seconds and integer sub-seconds, and this needs a more thorough review. But the immediate problem is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbfaden