net: improve GetIPAddresses() #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of type cast" due to netip.ParseAddr() not handling net.IPNet cases correctly This reverts commit 955aa80.
|
Unmap() can be applied to all Addrs, in the case of an IPv4 it is a no-op, I guess cheaper than an |
Signed-off-by: Alejandro Mery <[email protected]>
…nversion Signed-off-by: Alejandro Mery <[email protected]>
Signed-off-by: Alejandro Mery <[email protected]>
|
as discussed the PR was amended and now it reverts the change to use netip.ParseAddr(), that way we can forget about zones and networks. and it automatically unmaps 4in6 addresses into normal ipv4 ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert usage of netip.ParseAddr() because it doesn't handle cidr properly
and simplify the case where no interfaces are specified