Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-sys: add Makefile compatible with darvaza's but mono-project #3

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

amery
Copy link
Contributor

@amery amery commented Jan 12, 2023

same as darvaza's but without the subproject handling

@amery amery requested a review from karasz January 12, 2023 19:29
Copy link
Collaborator

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM comments are mostly cosmetic.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@amery
Copy link
Contributor Author

amery commented Jan 13, 2023

@karasz amended

Copy link
Collaborator

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now looks perfect

@amery amery merged commit 72c4b5a into main Jan 13, 2023
@amery amery deleted the pr-amery-buildsys branch January 13, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants