Add GetIPAddress() #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is mostly a call for discussion. @karasz
|
Signed-off-by: Alejandro Mery <[email protected]>
amery
force-pushed
the
pr-amery-GetIPAddress
branch
from
fec2cee
to
42d07f2
Compare
|
or maybe use an existing third-party dependency? does harshicorp have something already? |
Signed-off-by: Alejandro Mery <[email protected]>
karasz
approved these changes
Jan 10, 2023
| s = v.IP | ||
| } | ||
|
|
||
| if ip, ok := netip.AddrFromSlice(s); ok { |
There was a problem hiding this comment.
Well, if I want to be nitpicking (which I don't) I would say that there are 3 possible results that come from AddrFromSlice (IPv4 if the slice length is 4) and either a IPv6 mapped IPv4 or a standard IPv6 if the slice length is 16. The thing is that you cannot actually distinguish between the later two options easily, the question is do we care? at this point I think we do not care so I will approve.
There was a problem hiding this comment.
I think those are supposed to be treated as IPv6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GetIPAddresses() and a dumb GetIPAddress()