Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce complexities highlighted by revive 1.3.4 and test under Go 1.21 #23

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

amery
Copy link
Contributor

@amery amery commented Sep 20, 2023

No description provided.

@amery amery requested a review from karasz September 20, 2023 17:30
@@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: [ '1.19', '1.20' ]
go: [ '1.19', '1.20', '1.21' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop Go 1.19

Signed-off-by: Alejandro Mery <[email protected]>
for uniformity across repositories

Signed-off-by: Alejandro Mery <[email protected]>
Copy link
Contributor

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amery amery merged commit 830b90b into main Sep 21, 2023
5 checks passed
@amery amery deleted the pr-amery-revive branch September 21, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants