improve handling of empty queues

dartungar · Mar 31, 2024 · 376bc34 · 376bc34
1 parent 860048c
commit 376bc34
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,7 +1,7 @@
 {
  "id": "simple-note-review",
  "name": "Simple Note Review",
- "version": "1.2.4",
+ "version": "1.2.5",
  "minAppVersion": "1.1.0",
  "description": "Simple, customizable plugin for easy note review, resurfacing & repetition.",
  "author": "dartungar",

diff --git a/src/queues/reviewService.ts b/src/queues/reviewService.ts
@@ -75,8 +75,6 @@ export class ReviewService {
  await this.openNextNoteInQueue(noteSet);
  }
 
-
-
  private async removeNoteFromQueue(
  note: TAbstractFile,
  noteSet: INoteSet
@@ -86,12 +84,9 @@ export class ReviewService {
  }
 
  private async openNextNoteInQueue(noteSet: INoteSet): Promise<void> {
- const errorMsgBase = `Error opening next note in note set ${noteSet.displayName}: `;
- if (
- noteSet.queue?.filenames?.length &&
- noteSet.queue?.filenames?.length === 0
- ) {
- this._plugin.showNotice(errorMsgBase + "review queue is empty.");
+ const errorMsgBase = `Error opening next note in note set ${noteSet.displayName}: \n`;
+ if (!noteSet.queue?.filenames?.length) {
+ this._plugin.showNotice(errorMsgBase + "review queue is empty. Check note set in plugin settings.");
  return;
  }
  const filePath = noteSet.queue.filenames[0];