Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log vm service rpc errors in verbose mode #456

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Log vm service rpc errors in verbose mode #456

merged 1 commit into from
Jun 18, 2019

Conversation

jakemac53
Copy link
Contributor

@jakemac53 jakemac53 commented Jun 18, 2019

  • added onResponse and onRequest listeners to dwds
  • use onResponse to log failed responses in verbose mode for webdev (logged at warning level, some are always expected right now).

Closes #451

@jakemac53 jakemac53 requested a review from grouma June 18, 2019 21:46
@grouma grouma merged commit e38e5ef into master Jun 18, 2019
@grouma grouma deleted the i-can-haz-logs branch June 18, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way of logging requests/responses from dwds
2 participants