-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ffi] Varargs should give an error on uint8, int8, uint16, int16 and float #56058
Comments
hey |
Hi @vaishnavi-2901! That's great! Please start with https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md A PR for this issue will involve adding error messages both to the CFE (the compiler used when doing Some pointers to point you in the right direction:
It's probably easiest to
|
hey sir can i work on it ..? |
@vaishnavi-2901 are you still working on this? |
Dear respected sir let she work and let me also work on it. as I am beginning the open source contribution first you will check the request of both and then you will see what to do |
Passing 8 bit or 16 bit ints in varargs is undefined behavior.
Clang will alert us:
But we allow this in
dart:ffi
, leading to undefined behavior.We should consider adding an error message.
Discovered on:
The text was updated successfully, but these errors were encountered: