This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Update LICENSE #377
Merged
Update LICENSE #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to comply to internal review
natebosch
added a commit
that referenced
this pull request
Jun 7, 2021
#377 PiperOrigin-RevId: 378022812
natebosch
added a commit
that referenced
this pull request
Jun 7, 2021
#377 PiperOrigin-RevId: 378022812
natebosch
added a commit
that referenced
this pull request
Jun 8, 2021
* Refactor the pattern for skipping tests Use the `skip` argument so that tests are reported as skipped consistently across all reporters rather than output with `print` which is easily missed. Use a single list of unsupported chrome locales for both short and long formats. It is not useful to run tests for the locales that coincidentally match the fallback. Keep the variables separate since there will become new locales that are only skipped for short formats. Make some utility methods inside test files private. PiperOrigin-RevId: 359697870 * Skip some locales for web tests Skip the locales that cause failures in chrome version 88. This should unblock running tests on CI in github. PiperOrigin-RevId: 360139777 * Add optional parameter to NumberFormat.compact() to provide custom pattern. In Play Console UI we need to format positive values that represent a change with explicit + sign. CompactNumberFormat does not allow us to do so. #custom_kpi PiperOrigin-RevId: 361142234 * Remove the const tag for date time pattern data - The file documentation says it's generated by google3/i18n/tools/generate_datetime_pattern_dart.cc, but the generator file is out of sync with the generated file since 2020-08-19. I just followed the previous CLs and manually edited the file. PiperOrigin-RevId: 377081517 * Collapse null safety changelogs PiperOrigin-RevId: 377975405 * Organize imports f22f7b5 PiperOrigin-RevId: 378011273 * Exclude github config from sync These files can be maintained on github exclusively. PiperOrigin-RevId: 378013048 * Update LICENSE #377 PiperOrigin-RevId: 378022812 * Use correct stable version for ffi dep PiperOrigin-RevId: 378025311 * Restore github config Co-authored-by: Googler <[email protected]>
mosuem
pushed a commit
to dart-lang/i18n
that referenced
this pull request
Mar 2, 2023
* Refactor the pattern for skipping tests Use the `skip` argument so that tests are reported as skipped consistently across all reporters rather than output with `print` which is easily missed. Use a single list of unsupported chrome locales for both short and long formats. It is not useful to run tests for the locales that coincidentally match the fallback. Keep the variables separate since there will become new locales that are only skipped for short formats. Make some utility methods inside test files private. PiperOrigin-RevId: 359697870 * Skip some locales for web tests Skip the locales that cause failures in chrome version 88. This should unblock running tests on CI in github. PiperOrigin-RevId: 360139777 * Add optional parameter to NumberFormat.compact() to provide custom pattern. In Play Console UI we need to format positive values that represent a change with explicit + sign. CompactNumberFormat does not allow us to do so. #custom_kpi PiperOrigin-RevId: 361142234 * Remove the const tag for date time pattern data - The file documentation says it's generated by google3/i18n/tools/generate_datetime_pattern_dart.cc, but the generator file is out of sync with the generated file since 2020-08-19. I just followed the previous CLs and manually edited the file. PiperOrigin-RevId: 377081517 * Collapse null safety changelogs PiperOrigin-RevId: 377975405 * Organize imports dart-archive/intl@f22f7b5 PiperOrigin-RevId: 378011273 * Exclude github config from sync These files can be maintained on github exclusively. PiperOrigin-RevId: 378013048 * Update LICENSE dart-archive/intl#377 PiperOrigin-RevId: 378022812 * Use correct stable version for ffi dep PiperOrigin-RevId: 378025311 * Restore github config Co-authored-by: Googler <[email protected]>
mosuem
pushed a commit
to dart-lang/i18n
that referenced
this pull request
Apr 18, 2023
* Refactor the pattern for skipping tests Use the `skip` argument so that tests are reported as skipped consistently across all reporters rather than output with `print` which is easily missed. Use a single list of unsupported chrome locales for both short and long formats. It is not useful to run tests for the locales that coincidentally match the fallback. Keep the variables separate since there will become new locales that are only skipped for short formats. Make some utility methods inside test files private. PiperOrigin-RevId: 359697870 * Skip some locales for web tests Skip the locales that cause failures in chrome version 88. This should unblock running tests on CI in github. PiperOrigin-RevId: 360139777 * Add optional parameter to NumberFormat.compact() to provide custom pattern. In Play Console UI we need to format positive values that represent a change with explicit + sign. CompactNumberFormat does not allow us to do so. #custom_kpi PiperOrigin-RevId: 361142234 * Remove the const tag for date time pattern data - The file documentation says it's generated by google3/i18n/tools/generate_datetime_pattern_dart.cc, but the generator file is out of sync with the generated file since 2020-08-19. I just followed the previous CLs and manually edited the file. PiperOrigin-RevId: 377081517 * Collapse null safety changelogs PiperOrigin-RevId: 377975405 * Organize imports dart-archive/intl@5190155 PiperOrigin-RevId: 378011273 * Exclude github config from sync These files can be maintained on github exclusively. PiperOrigin-RevId: 378013048 * Update LICENSE dart-archive/intl#377 PiperOrigin-RevId: 378022812 * Use correct stable version for ffi dep PiperOrigin-RevId: 378025311 * Restore github config Co-authored-by: Googler <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to comply to internal review