OutputPath is not really optional #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #27 +/- ##
============================================
+ Coverage 85.73% 86.63% +0.89%
- Complexity 201 202 +1
============================================
Files 24 24
Lines 561 561
============================================
+ Hits 481 486 +5
+ Misses 80 75 -5
Continue to review full report at Codecov.
|
darrynten
requested changes
Apr 3, 2018
tests/Pslayers/PslayersTest.php
Outdated
|
|
||
| $instance->addLayer($backgroundLayer, 0); | ||
| $instance->addLayer($gradientLayer, 1); | ||
| $instance->render(); |
There was a problem hiding this comment.
Can we add some assertions after this to ensure what we get is what we want?
Ensure the filetype, the size etc is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes you may want to generate images in memory, without the images being saved to an output file. Whenever you don't supply an $outputPath it errors saying
Undefined property: DarrynTen\Pslayers\Config\Config::$outputPath, even though this option is optional. This is because it checks the property without fist checking if it is null.How I fixed it
I first checked if the $outputpath is set, then check if it is null. I also added tests that were failing before, but now pass as a result of this change.
@darrynten