feat: Implement timeout when resolving blocks #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, we wait an indefinite amount of time for a block to be resolved, which includes asking peers via bitswap, searching over dht for providers, etc., however this is not a desirable behaviour as the node may wish to cancel or abort the event at some point if no block is discovered within a duration.
This PR implements a timeout in
Repo::get_block_with_sessionwhile it is awaiting on bitswap to perform actions to fetch the block. TheIpfsapi will only default to 60 seconds while setting a timeout can be done withinIpfsUnixfs,IpfsDagorRepo.