Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dapr multirun from CLI. #243

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

artursouza
Copy link
Member

Signed-off-by: Artur Souza [email protected]

It works but I still get an error if I try to update CLI. There is a difference in version being used by runtime and CLI for k8s.io/client-go. We might need a new RC for CLI.

$ go get -u github.com/dapr/[email protected]
go: downloading golang.org/x/net v0.6.0
github.com/dapr/cli imports
        github.com/dapr/cli/cmd imports
        github.com/dapr/cli/pkg/kubernetes imports
        k8s.io/client-go/plugin/pkg/client/auth/openstack: cannot find module providing package k8s.io/client-go/plugin/pkg/client/auth/openstack

@artursouza
Copy link
Member Author

I verified it worked on standalone mode.

Copy link
Contributor

@mukundansundar mukundansundar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artursouza related to this dapr/cli#1114

go.mod Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #243 (6eec5b3) into master (e741698) will decrease coverage by 0.48%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #243      +/-   ##
==========================================
- Coverage   14.49%   14.02%   -0.48%     
==========================================
  Files           7        7              
  Lines         476      492      +16     
==========================================
  Hits           69       69              
- Misses        401      417      +16     
  Partials        6        6              
Impacted Files Coverage Δ
pkg/components/components.go 0.00% <0.00%> (ø)
pkg/configurations/configurations.go 0.00% <0.00%> (ø)
pkg/instances/instances.go 13.78% <0.00%> (-0.20%) ⬇️
pkg/version/version.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@artursouza artursouza merged commit b4d7a59 into dapr:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants