-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up windows CI/CD #1982
Speed up windows CI/CD #1982
Conversation
/ok-to-test |
/ok-to-wintest |
Found the available test cluster - dapr-aks-e2e-05. Please wait until test is done. |
Found the available test cluster - dapr-aks-e2e-06. Please wait until test is done. |
End-to-end tests failed. |
4035ef6
to
a847a3b
Compare
/ok-to-wintest |
Found the available test cluster - dapr-aks-e2e-06. Please wait until test is done. |
End-to-end tests failed. |
1 similar comment
End-to-end tests failed. |
a847a3b
to
a1f48d1
Compare
/ok-to-test |
Found the available test cluster - dapr-aks-e2e-06. Please wait until test is done. |
Congrats! All end-to-end tests have passed. Thanks for your contribution! |
/ok-to-wintest |
Found the available test cluster - dapr-aks-e2e-05. Please wait until test is done. |
End-to-end tests failed. |
/ok-to-wintest |
Found the available test cluster - dapr-aks-e2e-05. Please wait until test is done. |
End-to-end tests failed. |
a1f48d1
to
cd08e67
Compare
/ok-to-wintest |
Found the available test cluster - dapr-aks-e2e-05. Please wait until test is done. |
Congrats! All end-to-end tests have passed. Thanks for your contribution! |
cd08e67
to
1af765b
Compare
1af765b
to
f3bd9c0
Compare
/ok-to-perf |
Found the available test cluster - dapr-aks-e2e-05. Please wait until test is done. |
All Dapr perf tests completed. |
tests/dapr_tests.mk
Outdated
|
||
# start all perf tests | ||
test-perf-all: check-e2e-env | ||
DAPR_TEST_NAMESPACE=$(DAPR_TEST_NAMESPACE) DAPR_TEST_TAG=$(DAPR_TEST_TAG) DAPR_TEST_REGISTRY=$(DAPR_TEST_REGISTRY) DAPR_TEST_MINIKUBE_IP=$(MINIKUBE_NODE_IP) go test -p 1 -count=1 -v -tags=perf ./tests/perf/... | ||
DAPR_TEST_NAMESPACE=$(DAPR_TEST_NAMESPACE) DAPR_TEST_TAG=$(DAPR_TEST_TAG) DAPR_TEST_REGISTRY=$(DAPR_TEST_REGISTRY) DAPR_TEST_MINIKUBE_IP=$(MINIKUBE_NODE_IP) go test -p 2 -count=1 -v -tags=perf ./tests/perf/... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep it as 1 for perf test :) otherwise, two perf test can run in parallel, which results in the wrong perf number.
cc/ @yaron2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Will fix.
/ok-to-test |
Found the available test cluster - dapr-aks-e2e-05 for linux. Please wait until test is done. |
Found the available test cluster - dapr-aks-e2e-06 for windows. Please wait until test is done. |
End-to-end tests failed on linux. |
End-to-end tests cancelled on windows. |
/ok-to-test |
Found the available test cluster - dapr-aks-e2e-05 for linux. Please wait until test is done. |
Found the available test cluster - dapr-aks-e2e-06 for windows. Please wait until test is done. |
Congrats! All end-to-end tests have passed on linux. Thanks for your contribution! |
End-to-end tests failed on windows. |
Description
This PR contains several improvements to E2E tests for both linux and windows tests.
These improvements gets the tests down to ~20 minutes for linux and ~30 minutes for windows. Since this is even better than our current test runtime (~30-40 minutes) we should be able to run both in parallel each time we do /ok-to-test
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1944
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: