Only deploy docs when build from main branch #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[doc] gh action: only deploy docs when build from main branch
|
why closed? |
|
LGTM - thx for fixing this @m-birke I only changed the commit message and did not want to force push to your fork's main branch, so this is marked as closed, not as merged. You could resolve the conflict in your fork now by either force pushing daphne-eu/main to m-birke/main or by hard resetting your m-birke/main to daphne-eu/main. |
|
ah okay thanks :) would have been okay, next time again from feature branch, its more convenient |
DamianDinoiu
pushed a commit
to DamianDinoiu/daphne
that referenced
this pull request
Jan 29, 2024
This commit should fix the failing documentation deployment gh action. Closes daphne-eu#586
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs are still built (but not deployed) for any PR to main branch