Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using black & isort on codebase #103

Merged
merged 9 commits into from
Jan 15, 2022

Conversation

danthedeckie
Copy link
Owner

With testing in CI to go with it.

@danthedeckie danthedeckie added this to the 0.9.x "last release" milestone Jan 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #103 (d98f395) into 0.9.12 (05d9e02) will increase coverage by 0.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           0.9.12     #103      +/-   ##
==========================================
+ Coverage   98.99%   99.89%   +0.90%     
==========================================
  Files           2        2              
  Lines         996      993       -3     
  Branches      185        0     -185     
==========================================
+ Hits          986      992       +6     
+ Misses          4        1       -3     
+ Partials        6        0       -6     
Impacted Files Coverage Δ
simpleeval.py 99.64% <100.00%> (+1.76%) ⬆️
test_simpleeval.py 100.00% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05d9e02...d98f395. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Jan 15, 2022

Hello @danthedeckie! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 122:80: E501 line too long (84 > 79 characters)
Line 149:80: E501 line too long (85 > 79 characters)
Line 163:80: E501 line too long (91 > 79 characters)
Line 173:80: E501 line too long (83 > 79 characters)
Line 221:80: E501 line too long (86 > 79 characters)
Line 242:80: E501 line too long (84 > 79 characters)
Line 250:80: E501 line too long (86 > 79 characters)
Line 257:80: E501 line too long (86 > 79 characters)
Line 375:80: E501 line too long (93 > 79 characters)
Line 398:80: E501 line too long (94 > 79 characters)
Line 408:80: E501 line too long (99 > 79 characters)
Line 414:80: E501 line too long (99 > 79 characters)
Line 430:80: E501 line too long (80 > 79 characters)
Line 436:80: E501 line too long (82 > 79 characters)
Line 439:80: E501 line too long (84 > 79 characters)
Line 447:80: E501 line too long (91 > 79 characters)
Line 476:80: E501 line too long (90 > 79 characters)
Line 493:80: E501 line too long (93 > 79 characters)
Line 541:80: E501 line too long (81 > 79 characters)
Line 619:80: E501 line too long (87 > 79 characters)
Line 664:80: E501 line too long (86 > 79 characters)

Line 1:80: E501 line too long (123 > 79 characters)
Line 142:80: E501 line too long (84 > 79 characters)
Line 412:80: E501 line too long (96 > 79 characters)
Line 418:80: E501 line too long (82 > 79 characters)
Line 517:80: E501 line too long (97 > 79 characters)
Line 624:80: E501 line too long (85 > 79 characters)
Line 681:80: E501 line too long (98 > 79 characters)
Line 907:80: E501 line too long (80 > 79 characters)
Line 933:80: E501 line too long (96 > 79 characters)
Line 1111:80: E501 line too long (83 > 79 characters)
Line 1124:80: E501 line too long (83 > 79 characters)
Line 1142:80: E501 line too long (98 > 79 characters)

Comment last updated at 2022-01-15 17:28:19 UTC

@danthedeckie danthedeckie merged commit 9a0f4f2 into 0.9.12 Jan 15, 2022
@danthedeckie danthedeckie deleted the black-isort-format-lint-stuff branch January 15, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants