Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-prioritize "any" typed function signatures #205

Merged
merged 1 commit into from
Nov 6, 2021

Conversation

iancamp
Copy link
Contributor

@iancamp iancamp commented Oct 7, 2021

Fixes #185.

I've verified it at least results in the type of obj being preserved when doing something like *ngFor="let obj of arrayOfTypedObjects | orderBy: ....

Additionally, I improved the typing of the pluckBy pipe.

NOTE: I would appreciate it if this PR could have the "hacktoberfest-accepted" label added :)

Copy link
Owner

@danrevah danrevah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job.

@danrevah danrevah merged commit 00e8038 into danrevah:master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FilterBy Pipe returning generic any[]
2 participants