Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the "remember" field excluded from login.html? #39

Open
Hyperz opened this issue Jan 6, 2024 · 3 comments
Open

Why is the "remember" field excluded from login.html? #39

Hyperz opened this issue Jan 6, 2024 · 3 comments

Comments

@Hyperz
Copy link

Hyperz commented Jan 6, 2024

I'm referring to this. Is there a reason the "Remember me" checkbox is being excluded from the form entirely?

@danihodovic
Copy link
Owner

I can't remember why I made that decision. We should add it. Do you want to open a PR?

Instructions here: https://github.com/danihodovic/django-allauth-ui#hacking-on-the-project

@Hyperz
Copy link
Author

Hyperz commented Jan 7, 2024

Looking at what happens when the conditional is removed maybe it was put there to not give the checkbox the same look/styling as the email/password fields, so maybe it was supposed to be an if-else instead of just an if conditional?

As for a PR, I'd love to but I'm still learning Django and Tailwind so I can't right now unfortunately.

@danihodovic
Copy link
Owner

I will see if I can open a PR. Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants