Change the listen command to run indefinitely and retry should usbmuxd be killed #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of log.Fatal failing
…will keep going and trying to reconnect until it receives a SIGTERM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the code still execute a
log.Fatalrather than returning an error. This is a leftover form my initial days of golang learning and now I think it is not a good idea for several reasons.This PR removes log.Fatal for deviceconnection.go and usbmuxconnection.go and replaces it with returning an error.
I need those to return an actual error so I can try to reconnect in an endless loop for the
LISTENcommand rather than exitting and failing the command.