Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fsync fd, fd leak and export some useful method #244

Merged
merged 4 commits into from
May 8, 2023

Conversation

prife
Copy link
Contributor

@prife prife commented Mar 8, 2023

  1. fix fsync fd > 256
  2. close connection fd in ListDevices and ReadPair
  3. return error when EnableSSL failed
  4. export dtx.decodeAuxiliary for custom use

@danielpaulus
Copy link
Owner

hey @prife sorry for the late response, I was hacking on activation, erasing and supervising devices and finally got it done. It caused some conflicts with your PR. Would you be so kind and resolve those?
Thank you so much for contributing to go-iOS :-)

@prife
Copy link
Contributor Author

prife commented May 8, 2023

Got it, I will fix confilcts today.

@prife
Copy link
Contributor Author

prife commented May 8, 2023

hey @prife sorry for the late response, I was hacking on activation, erasing and supervising devices and finally got it done. It caused some conflicts with your PR. Would you be so kind and resolve those? Thank you so much for contributing to go-iOS :-)

Hi dainel, I've already fix the PR's conflict, now it works with the latest code

Copy link
Owner

@danielpaulus danielpaulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@danielpaulus danielpaulus merged commit 799a5e0 into danielpaulus:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants