fix: enforce path params are required #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huma marks path params as required when generating the OpenAPI docs, which complies with OpenAPI 3.0. However, Huma does not check if path params values are non-empty during runtime.
For example, in the bookstore example, not providing the
genre-id
will result in a 404 after failing to find an empty genre instead of a 400.Huma uses the
Chi
router which does not mark path parameters as required unless regex or additional custom logic is added. This PR modifies theresolver
to check if a path param value is empty and throws an error instead of continuing.The new output for the same bookstore request is as follows: