-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve file limit handling #4242
Conversation
4316dbb
to
88c1806
Compare
Code wise looks ok (as usual). |
For the database migrations, assuming it's possible, should a check be done on the metadata table to ensure there are no rows with negative file sizes? If not, then any existing negative values will continue to incorrectly increase the available limit calculations. |
migrations/postgresql/2024-01-12-210182_change_attachment_size/up.sql
Outdated
Show resolved
Hide resolved
We could search for all values less then 0, and convert them. |
Convert them to simply |
In theory it would be possible to fix all this. All files are on disk of course, and we can match all attachments and send files. Though i do think there are probably no users who send negative files sizes to the server. We might be able to create an action in the admin interface to validate all attachments and sends maybe. |
Though i do think there are probably no users who send negative files sizes to the server.
Perhaps, perhaps not. The existence of attachment limits suggests that users can’t be trusted to not upload more than they should. A determined user can pretty easily hit the metadata endpoint uploading negative values to bypass those limits. This means that the probability a given user is willing to bypass attachment limits may not be as small as one may think. Finally you have the birthday paradox which highlights that even small probabilities exponentially grow as a function of the number of instances.
I think a better argument against the need is that any reasonably competent admin should be using additional means to ensure total storage size isn’t out of control; so if a user/org already has egregiously bypassed configured limits, it’d already be detected. If a user/org is just a little bit over, then it’s probably not a big deal.
|
fe551ee
to
cc9e1ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
LGTM too. |
…1.30.2@ab34a7b by renovate (#17766) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | patch | `1.30.1` -> `1.30.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (docker.io/vaultwarden/server)</summary> ### [`v1.30.2`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.2) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.1...1.30.2)⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - Prevent generating an error during ws close by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4127 - Update Rust, Crates, Profile and Actions by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4126 - Several small fixes for open issues by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4143 - Fix the version string by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4153 - Decrease JWT Refresh/Auth token by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4163 - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4173 - Add additional build target which optimizes for size by [@​gladiac](https://togithub.com/gladiac) in [dani-garcia/vaultwarden#4096 - Update web-vault to v2023.12.0 by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4201 - Update Rust and Crates by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4211 - Fix Single Org Policy check by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4207 - Allow customizing the featureStates by [@​PKizzle](https://togithub.com/PKizzle) in [dani-garcia/vaultwarden#4168 - Fix [#​3413](https://togithub.com/dani-garcia/vaultwarden/issues/3413): push to users accessing the collections using groups by [@​matlink](https://togithub.com/matlink) in [dani-garcia/vaultwarden#3757 - US or EU Data Region Selection by [@​toto-xoxo](https://togithub.com/toto-xoxo) in [dani-garcia/vaultwarden#3752 - enforce 2FA policy on removal of second factor and login by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3803 - improve emergency access when not enabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4227 - Update crates and fix icon issue by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4237 - Bump h2 from 0.3.23 to 0.3.24 by [@​dependabot](https://togithub.com/dependabot) in [dani-garcia/vaultwarden#4260 - Fix bulk collection deletion by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4257 - fix: use black text for update badge (better contrast) by [@​tessus](https://togithub.com/tessus) in [dani-garcia/vaultwarden#4245 - prevent side effects if groups are disabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4265 - Update crates, web-vault to 2024.1.2 and GHA by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4275 - Return 404 when user public_key is empty by [@​Timshel](https://togithub.com/Timshel) in [dani-garcia/vaultwarden#4271 - Improve file limit handling by [@​dani-garcia](https://togithub.com/dani-garcia) in [dani-garcia/vaultwarden#4242 - Fix attachment upload size check by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4282 - err on invalid feature flag by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4263 - register missing push devices at login by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3792 - Update env template file by [@​gzfrozen](https://togithub.com/gzfrozen) in [dani-garcia/vaultwarden#4276 #### New Contributors - [@​gladiac](https://togithub.com/gladiac) made their first contribution in [dani-garcia/vaultwarden#4096 - [@​PKizzle](https://togithub.com/PKizzle) made their first contribution in [dani-garcia/vaultwarden#4168 - [@​matlink](https://togithub.com/matlink) made their first contribution in [dani-garcia/vaultwarden#3757 - [@​toto-xoxo](https://togithub.com/toto-xoxo) made their first contribution in [dani-garcia/vaultwarden#3752 - [@​Timshel](https://togithub.com/Timshel) made their first contribution in [dani-garcia/vaultwarden#4271 - [@​gzfrozen](https://togithub.com/gzfrozen) made their first contribution in [dani-garcia/vaultwarden#4276 **Full Changelog**: dani-garcia/vaultwarden@1.30.1...1.30.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjIuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2Mi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
…1.30.2@ab34a7b by renovate (truecharts#17766) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | patch | `1.30.1` -> `1.30.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (docker.io/vaultwarden/server)</summary> ### [`v1.30.2`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.2) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.1...1.30.2)⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - Prevent generating an error during ws close by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4127 - Update Rust, Crates, Profile and Actions by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4126 - Several small fixes for open issues by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4143 - Fix the version string by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4153 - Decrease JWT Refresh/Auth token by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4163 - Update crates by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4173 - Add additional build target which optimizes for size by [@&truecharts#8203;gladiac](https://togithub.com/gladiac) in [dani-garcia/vaultwarden#4096 - Update web-vault to v2023.12.0 by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4201 - Update Rust and Crates by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4211 - Fix Single Org Policy check by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4207 - Allow customizing the featureStates by [@&truecharts#8203;PKizzle](https://togithub.com/PKizzle) in [dani-garcia/vaultwarden#4168 - Fix [#&truecharts#8203;3413](https://togithub.com/dani-garcia/vaultwarden/issues/3413): push to users accessing the collections using groups by [@&truecharts#8203;matlink](https://togithub.com/matlink) in [dani-garcia/vaultwarden#3757 - US or EU Data Region Selection by [@&truecharts#8203;toto-xoxo](https://togithub.com/toto-xoxo) in [dani-garcia/vaultwarden#3752 - enforce 2FA policy on removal of second factor and login by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3803 - improve emergency access when not enabled by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4227 - Update crates and fix icon issue by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4237 - Bump h2 from 0.3.23 to 0.3.24 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [dani-garcia/vaultwarden#4260 - Fix bulk collection deletion by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4257 - fix: use black text for update badge (better contrast) by [@&truecharts#8203;tessus](https://togithub.com/tessus) in [dani-garcia/vaultwarden#4245 - prevent side effects if groups are disabled by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4265 - Update crates, web-vault to 2024.1.2 and GHA by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4275 - Return 404 when user public_key is empty by [@&truecharts#8203;Timshel](https://togithub.com/Timshel) in [dani-garcia/vaultwarden#4271 - Improve file limit handling by [@&truecharts#8203;dani-garcia](https://togithub.com/dani-garcia) in [dani-garcia/vaultwarden#4242 - Fix attachment upload size check by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4282 - err on invalid feature flag by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4263 - register missing push devices at login by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3792 - Update env template file by [@&truecharts#8203;gzfrozen](https://togithub.com/gzfrozen) in [dani-garcia/vaultwarden#4276 #### New Contributors - [@&truecharts#8203;gladiac](https://togithub.com/gladiac) made their first contribution in [dani-garcia/vaultwarden#4096 - [@&truecharts#8203;PKizzle](https://togithub.com/PKizzle) made their first contribution in [dani-garcia/vaultwarden#4168 - [@&truecharts#8203;matlink](https://togithub.com/matlink) made their first contribution in [dani-garcia/vaultwarden#3757 - [@&truecharts#8203;toto-xoxo](https://togithub.com/toto-xoxo) made their first contribution in [dani-garcia/vaultwarden#3752 - [@&truecharts#8203;Timshel](https://togithub.com/Timshel) made their first contribution in [dani-garcia/vaultwarden#4271 - [@&truecharts#8203;gzfrozen](https://togithub.com/gzfrozen) made their first contribution in [dani-garcia/vaultwarden#4276 **Full Changelog**: dani-garcia/vaultwarden@1.30.1...1.30.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjIuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2Mi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
…1.30.2@ab34a7b by renovate (truecharts#17766) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [docker.io/vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | patch | `1.30.1` -> `1.30.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (docker.io/vaultwarden/server)</summary> ### [`v1.30.2`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.2) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.1...1.30.2)⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - Prevent generating an error during ws close by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4127 - Update Rust, Crates, Profile and Actions by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4126 - Several small fixes for open issues by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4143 - Fix the version string by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4153 - Decrease JWT Refresh/Auth token by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4163 - Update crates by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4173 - Add additional build target which optimizes for size by [@&truecharts#8203;gladiac](https://togithub.com/gladiac) in [dani-garcia/vaultwarden#4096 - Update web-vault to v2023.12.0 by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4201 - Update Rust and Crates by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4211 - Fix Single Org Policy check by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4207 - Allow customizing the featureStates by [@&truecharts#8203;PKizzle](https://togithub.com/PKizzle) in [dani-garcia/vaultwarden#4168 - Fix [#&truecharts#8203;3413](https://togithub.com/dani-garcia/vaultwarden/issues/3413): push to users accessing the collections using groups by [@&truecharts#8203;matlink](https://togithub.com/matlink) in [dani-garcia/vaultwarden#3757 - US or EU Data Region Selection by [@&truecharts#8203;toto-xoxo](https://togithub.com/toto-xoxo) in [dani-garcia/vaultwarden#3752 - enforce 2FA policy on removal of second factor and login by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3803 - improve emergency access when not enabled by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4227 - Update crates and fix icon issue by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4237 - Bump h2 from 0.3.23 to 0.3.24 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [dani-garcia/vaultwarden#4260 - Fix bulk collection deletion by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4257 - fix: use black text for update badge (better contrast) by [@&truecharts#8203;tessus](https://togithub.com/tessus) in [dani-garcia/vaultwarden#4245 - prevent side effects if groups are disabled by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4265 - Update crates, web-vault to 2024.1.2 and GHA by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4275 - Return 404 when user public_key is empty by [@&truecharts#8203;Timshel](https://togithub.com/Timshel) in [dani-garcia/vaultwarden#4271 - Improve file limit handling by [@&truecharts#8203;dani-garcia](https://togithub.com/dani-garcia) in [dani-garcia/vaultwarden#4242 - Fix attachment upload size check by [@&truecharts#8203;BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4282 - err on invalid feature flag by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4263 - register missing push devices at login by [@&truecharts#8203;stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3792 - Update env template file by [@&truecharts#8203;gzfrozen](https://togithub.com/gzfrozen) in [dani-garcia/vaultwarden#4276 #### New Contributors - [@&truecharts#8203;gladiac](https://togithub.com/gladiac) made their first contribution in [dani-garcia/vaultwarden#4096 - [@&truecharts#8203;PKizzle](https://togithub.com/PKizzle) made their first contribution in [dani-garcia/vaultwarden#4168 - [@&truecharts#8203;matlink](https://togithub.com/matlink) made their first contribution in [dani-garcia/vaultwarden#3757 - [@&truecharts#8203;toto-xoxo](https://togithub.com/toto-xoxo) made their first contribution in [dani-garcia/vaultwarden#3752 - [@&truecharts#8203;Timshel](https://togithub.com/Timshel) made their first contribution in [dani-garcia/vaultwarden#4271 - [@&truecharts#8203;gzfrozen](https://togithub.com/gzfrozen) made their first contribution in [dani-garcia/vaultwarden#4276 **Full Changelog**: dani-garcia/vaultwarden@1.30.1...1.30.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNjIuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE2Mi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | patch | `1.30.1-alpine` -> `1.30.5-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.30.5`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.5) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.4...1.30.5) #### What's Changed - fix: web API call for jquery 3.7.1 by [@​calvin-li-developer](https://togithub.com/calvin-li-developer) in [dani-garcia/vaultwarden#4400 #### New Contributors - [@​calvin-li-developer](https://togithub.com/calvin-li-developer) made their first contribution in [dani-garcia/vaultwarden#4400 **Full Changelog**: dani-garcia/vaultwarden@1.30.4...1.30.5 ### [`v1.30.4`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.4) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.3...1.30.4)⚠️ Note: The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - Update crates to fix new builds by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4308 - Add Kubernetes environment detection by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4290 - Update GHA Workflows by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4309 - Update Rust, crates and web-vault by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4328 - Change the codegen-units for low resources by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4336 - Fix env templateto ensure compatibility with systemd's EnvironmentFile parsing by [@​seiuneko](https://togithub.com/seiuneko) in [dani-garcia/vaultwarden#4315 - Update crates, GHA and a Python script by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4357 #### New Contributors - [@​seiuneko](https://togithub.com/seiuneko) made their first contribution in [dani-garcia/vaultwarden#4315 **Full Changelog**: dani-garcia/vaultwarden@1.30.3...1.30.4 ### [`v1.30.3`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.3) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.2...1.30.3) This is a minor release to fix some issues with push notification device registration and docker healthcheck.⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - fix push device registration by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4297 - Fix healthcheck when using .env file by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4299 **Full Changelog**: dani-garcia/vaultwarden@1.30.2...1.30.3 ### [`v1.30.2`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.2) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.30.1...1.30.2)⚠️ **Note:** The WebSockets service for live sync has been integrated in the main HTTP server, which means simpler proxy setups that don't require a separate rule to redirect WS traffic to port 3012. Please check the updated examples in the [wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples). It's recommended to migrate to this new setup as using the old server on port 3012 is deprecated, won't receive new features and will be removed in the next release. #### What's Changed - Prevent generating an error during ws close by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4127 - Update Rust, Crates, Profile and Actions by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4126 - Several small fixes for open issues by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4143 - Fix the version string by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4153 - Decrease JWT Refresh/Auth token by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4163 - Update crates by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4173 - Add additional build target which optimizes for size by [@​gladiac](https://togithub.com/gladiac) in [dani-garcia/vaultwarden#4096 - Update web-vault to v2023.12.0 by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4201 - Update Rust and Crates by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4211 - Fix Single Org Policy check by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4207 - Allow customizing the featureStates by [@​PKizzle](https://togithub.com/PKizzle) in [dani-garcia/vaultwarden#4168 - Fix [#​3413](https://togithub.com/dani-garcia/vaultwarden/issues/3413): push to users accessing the collections using groups by [@​matlink](https://togithub.com/matlink) in [dani-garcia/vaultwarden#3757 - US or EU Data Region Selection by [@​toto-xoxo](https://togithub.com/toto-xoxo) in [dani-garcia/vaultwarden#3752 - enforce 2FA policy on removal of second factor and login by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3803 - improve emergency access when not enabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4227 - Update crates and fix icon issue by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4237 - Bump h2 from 0.3.23 to 0.3.24 by [@​dependabot](https://togithub.com/dependabot) in [dani-garcia/vaultwarden#4260 - Fix bulk collection deletion by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4257 - fix: use black text for update badge (better contrast) by [@​tessus](https://togithub.com/tessus) in [dani-garcia/vaultwarden#4245 - prevent side effects if groups are disabled by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4265 - Update crates, web-vault to 2024.1.2 and GHA by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4275 - Return 404 when user public_key is empty by [@​Timshel](https://togithub.com/Timshel) in [dani-garcia/vaultwarden#4271 - Improve file limit handling by [@​dani-garcia](https://togithub.com/dani-garcia) in [dani-garcia/vaultwarden#4242 - Fix attachment upload size check by [@​BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#4282 - err on invalid feature flag by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#4263 - register missing push devices at login by [@​stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3792 - Update env template file by [@​gzfrozen](https://togithub.com/gzfrozen) in [dani-garcia/vaultwarden#4276 #### New Contributors - [@​gladiac](https://togithub.com/gladiac) made their first contribution in [dani-garcia/vaultwarden#4096 - [@​PKizzle](https://togithub.com/PKizzle) made their first contribution in [dani-garcia/vaultwarden#4168 - [@​matlink](https://togithub.com/matlink) made their first contribution in [dani-garcia/vaultwarden#3757 - [@​toto-xoxo](https://togithub.com/toto-xoxo) made their first contribution in [dani-garcia/vaultwarden#3752 - [@​Timshel](https://togithub.com/Timshel) made their first contribution in [dani-garcia/vaultwarden#4271 - [@​gzfrozen](https://togithub.com/gzfrozen) made their first contribution in [dani-garcia/vaultwarden#4276 **Full Changelog**: dani-garcia/vaultwarden@1.30.1...1.30.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIyMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Haven't tested MySQL or Postgres but I think the migrations are correct.