Update Rust and Crates #3563

tessus · 2023-06-03T21:08:36Z

Updated Rust to v1.70.0
Updated MSRV to v1.68.2
Updated crates

BlackDex

First of all, thanks!

I just noticed some missing updates. Of which a few were updated after your PR.
once_cell and cached are both updated, to 1.18.0 and 0.44.0

Further, you missed diesel_logger, which is currently at 0.3.0, which fixes compatibility with diesel v2.1.x.

A nice tool for some extra checks is https://crates.io/crates/cargo-outdated, you can then run cargo outdated -R to see all outdated crates. Some can't be updated like cookie and webauthn-rs for example. But most of the time others can.

Also, since I released the new web-vault just a few minutes ago, would be cool if you could add the new web-vault version also.

BlackDex · 2023-06-04T13:41:42Z

Cargo.toml

 fern = { version = "0.6.2", features = ["syslog-6"] }
 tracing = { version = "0.1.37", features = ["log"] } # Needed to have lettre and webauthn-rs trace logging to work

 # A `dotenv` implementation for Rust
 dotenvy = { version = "0.15.7", default-features = false }

 # Lazy initialization
-once_cell = "1.17.1"
+once_cell = "1.17.2"


Seems to be 1.18.0 already, just a few hours ago :)

Hmm, I can't travel to the future. ;-) Haha. When I ran the cargo update I only got that version.

Which is why I put that winking smiley...

tessus · 2023-06-04T19:41:08Z

I just noticed some missing updates. Of which a few were updated after your PR.
once_cell and cached are both updated, to 1.18.0 and 0.44.0

I'll check it out.

Further, you missed diesel_logger, which is currently at 0.3.0, which fixes compatibility with diesel v2.1.x.

Hmm, this was not shown in cargo update. Weird.

A nice tool for some extra checks is https://crates.io/crates/cargo-outdated, you can then run cargo outdated -R to see all outdated crates.

This is a great advise. I'll try using this tool, but I am getting a compile error when doing a cargo install --locked cargo-outdated on my my macOS. I have to look into it, or maybe I'll just use the Linux build VM for it.
For this PR I actually just ran cargo update and looked at what was in the cargo.toml and updated them, but this tool seems much better.

Also, since I released the new web-vault just a few minutes ago, would be cool if you could add the new web-vault version also.

Will do.

tessus · 2023-06-04T20:16:38Z

Some can't be updated like cookie and webauthn-rs for example.

Ok, I have updated all but those 2. I've also updated the web-vault to v2023.5.0.

BlackDex · 2023-06-04T20:23:05Z

Some can't be updated like cookie and webauthn-rs for example.

Ok, I have updated all but those 2. I've also updated the web-vault to v2023.5.0.

Great thx again!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) | stage | minor | `1.28.1-alpine` -> `1.29.0-alpine` | --- ### Release Notes <details> <summary>dani-garcia/vaultwarden (vaultwarden/server)</summary> ### [`v1.29.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.29.0) [Compare Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.28.1...1.29.0) #### Major changes and New Features - WebSocket notifications now work via the default HTTP port. No need for `WEBSOCKET_ENABLED` and a separate port anymore. The proxy examples still need to be updated for this. Support for the old websockets port 3012 will remain for the time being. - Mobile Client push notification support, see [#3304](https://togithub.com/dani-garcia/vaultwarden/issues/3304) thanks [@GeekCornerGH](https://togithub.com/GeekCornerGH)! - Web-Vault updated to v2023.5.0 (v2023.5.1 does not add any improvements for us) - The latest Bitwarden Directory Connector can be used now ([v2022.11.0](https://togithub.com/bitwarden/directory-connector/releases/tag/v2022.11.0)) - [Storing passkeys](https://bitwarden.com/passwordless-passkeys) is supported, though the clients are not yet released. So, it might be we need to make some changes once they are released. See: [#3593](https://togithub.com/dani-garcia/vaultwarden/issues/3593), thanks [@GeekCornerGH](https://togithub.com/GeekCornerGH)! #### What's Changed - check if reset password policy is enabled by [@stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3427 - WebSockets via Rocket's Upgrade connection by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3404 - Several config and admin interface fixes by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3436 - Fixed missing footer_text and a few inconsistencies in email templates by [@kennymc-c](https://togithub.com/kennymc-c) in [dani-garcia/vaultwarden#3439 - Small update to Rocket WebSockets by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3440 - inline static rsa keys by [@vilgotf](https://togithub.com/vilgotf) in [dani-garcia/vaultwarden#3475 - Update Rust and Crates by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3469 - Change `String` to `&str` for all Rocket functions and some other fixes by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3491 - Use Rocket `v0.5` branch to fix endpoints by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3502 - Use fully qualified image names in Dockerfile by [@gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) in [dani-garcia/vaultwarden#3505 - policy data should be `null` not an empty object by [@stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3513 - update web-vault to v2023.4.2 by [@stefan0xC](https://togithub.com/stefan0xC) in [dani-garcia/vaultwarden#3522 - Sync global_domains.json (Pinterest) by [@jjlin](https://togithub.com/jjlin) in [dani-garcia/vaultwarden#3532 - Prevent 401 on main admin page by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3547 - Update crates and GH Workflow by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3548 - Fix collection change ws notifications by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3546 - Update Rust and Crates by [@tessus](https://togithub.com/tessus) in [dani-garcia/vaultwarden#3563 - feat: Implement Push Notifications sync by [@GeekCornerGH](https://togithub.com/GeekCornerGH) in [dani-garcia/vaultwarden#3304 - Implement the Organization API Key support for the new Directory Connector v2022 by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3568 - Add mobile push device filter to non-null push uuid by [@quexten](https://togithub.com/quexten) in [dani-garcia/vaultwarden#3578 - Update crates and workflow by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3603 - Add group import on invite by [@farodin91](https://togithub.com/farodin91) in [dani-garcia/vaultwarden#3606 - Fix send access regression by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3608 - feat: Support for storing passkeys in the vault by [@GeekCornerGH](https://togithub.com/GeekCornerGH) in [dani-garcia/vaultwarden#3593 - add user to collection during creation by [@farodin91](https://togithub.com/farodin91) in [dani-garcia/vaultwarden#3609 - Updated docker run command by [@DenuxPlays](https://togithub.com/DenuxPlays) in [dani-garcia/vaultwarden#3620 - Added-External_id for Collections by [@fashberg](https://togithub.com/fashberg) in [dani-garcia/vaultwarden#3623 - fix missing password check while manual reset password enrollment by [@sirux88](https://togithub.com/sirux88) in [dani-garcia/vaultwarden#3632 - Update crates and small clippy fix by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3649 - fix version when compiled at a specific commit by [@tessus](https://togithub.com/tessus) in [dani-garcia/vaultwarden#3651 - Fix org creation regresion by [@BlackDex](https://togithub.com/BlackDex) in [dani-garcia/vaultwarden#3659 #### New Contributors - [@kennymc-c](https://togithub.com/kennymc-c) made their first contribution in [dani-garcia/vaultwarden#3439 - [@vilgotf](https://togithub.com/vilgotf) made their first contribution in [dani-garcia/vaultwarden#3475 - [@gitouche-sur-osm](https://togithub.com/gitouche-sur-osm) made their first contribution in [dani-garcia/vaultwarden#3505 - [@quexten](https://togithub.com/quexten) made their first contribution in [dani-garcia/vaultwarden#3578 - [@DenuxPlays](https://togithub.com/DenuxPlays) made their first contribution in [dani-garcia/vaultwarden#3620 - [@fashberg](https://togithub.com/fashberg) made their first contribution in [dani-garcia/vaultwarden#3623 **Full Changelog**: dani-garcia/vaultwarden@1.28.1...1.29.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Update Rust and Crates

06a10e2

BlackDex requested changes Jun 4, 2023

View reviewed changes

tessus added 2 commits June 4, 2023 16:14

Update a few more crates

2d6ca0e

update web-vault to v2023.5.0

f40f5b8

BlackDex approved these changes Jun 4, 2023

View reviewed changes

BlackDex merged commit adf67a8 into dani-garcia:main Jun 4, 2023
3 checks passed

tessus deleted the update/rust-and-crates branch June 4, 2023 22:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Rust and Crates #3563

Update Rust and Crates #3563

tessus commented Jun 3, 2023

BlackDex left a comment

BlackDex Jun 4, 2023

tessus Jun 4, 2023

BlackDex Jun 4, 2023

tessus Jun 4, 2023

tessus commented Jun 4, 2023

tessus commented Jun 4, 2023

BlackDex commented Jun 4, 2023

Update Rust and Crates #3563

Update Rust and Crates #3563

Conversation

tessus commented Jun 3, 2023

BlackDex left a comment

Choose a reason for hiding this comment

BlackDex Jun 4, 2023

Choose a reason for hiding this comment

tessus Jun 4, 2023

Choose a reason for hiding this comment

BlackDex Jun 4, 2023

Choose a reason for hiding this comment

tessus Jun 4, 2023

Choose a reason for hiding this comment

tessus commented Jun 4, 2023

tessus commented Jun 4, 2023

BlackDex commented Jun 4, 2023