Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include information about GIT_PAGER in manual #991

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

katylava
Copy link
Contributor

@katylava katylava commented Feb 26, 2022

under configuration instructions

delta is so awesome that I spent hours trying to get it to work, and eventually found this little thorn in my env. Not sure this is where you'd want to mention it, but I think it's worth mentioning somehow, somewhere.

under configuration instructions
@@ -31,6 +31,8 @@ The most convenient way to configure delta is with a `[delta]` section in `~/.gi

</sub>

If you have the `GIT_PAGER` environment variable set, you'll need to unset it.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katylava, good call! This is definitely worth mentioning. Shall we maybe tweak that to say that they can set GIT_PAGER=delta, or unset it?

Copy link
Contributor Author

@katylava katylava Feb 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think saying more would require more explanation as well, and since the documentation on this page is just to get people started, it should probably be kept short. Like I think if you say they can set it, you'll also have to explain that it overrides what is in .gitconfig under core.pager. And then explain why they might want it in one place over the other.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right. OK, thanks a lot -- I'll merge this now and maybe explain more later.

(It might be nice at some point to make a delta doctor command that, among other things, would check for relevant environment variables and warn if they look like not what the user wanted.)

@dandavison dandavison merged commit 56de497 into dandavison:master Feb 26, 2022
@katylava katylava deleted the patch-1 branch February 26, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants