Fall back to plain diff when process substitution is used #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When detecting input generated by `delta <(echo foo) <(echo bar)` fall back to plain `diff` instead of `git diff --no-index`. This does not respect various git settings anymore (the original reason to switch from `diff` to `git diff`), but is better than just showing the names of the temporary files.
|
Hi Thomas, do you think there's a viable alternative involving working with the file descriptor(s) and/or creating temporary files, along the lines of the discussion here: #929 (comment) ? If possible I'd really like to keep the behavior consistent and use |
|
That approach looks great and all the caveats I could think of are already being discussed, I like the piping-to-stdin so only one tmp-file has to be created. But in the meantime, isn't perfect the enemy of good (enough)? :) |
Yes, you're right! I just wanted to check that you're on board with the other solution. (I'm not aware that it's being actively worked on.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When detecting input generated by
delta <(echo foo) <(echo bar)fall back to plain
diffinstead ofgit diff --no-index.This does not respect various git settings anymore (the original reason
to switch from
difftogit diff), but is better than just showingthe names of the temporary files.