Fix issue where pager would be set to more
or most
#1494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Colors wouldn't render properly in case the
![20230729_23h00m14s_grim](https://private-user-images.githubusercontent.com/69125922/257014771-db3dc0db-677e-4a26-917e-fc330a5f6998.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI5NTg4NzMsIm5iZiI6MTcyMjk1ODU3MywicGF0aCI6Ii82OTEyNTkyMi8yNTcwMTQ3NzEtZGIzZGMwZGItNjc3ZS00YTI2LTkxN2UtZmMzMzBhNWY2OTk4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA2VDE1MzYxM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY3MDU5ZTFiZmZjNzdkNmIwZDNjZjI1Mzg2ODgwNDY4MzNkNzcyODE3YzJlNDVjNDkwMjkwZWFjMTk0MGQzOTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2uKu6pi0TrwkgAZgMmrf8Oe5qM63QKS2hjgj4THBPaM)
$PAGER
is set tomore
ormost
.(fix for #1490 )Solution
Handle the case where
$PAGER
is set tomore
ormost
by usingbat::config::get_pager_executable
which sets the pager toless
if that's the case.Unit tests: