Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Provides in Debian package #1217

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Remove Provides in Debian package #1217

merged 1 commit into from
Nov 15, 2022

Conversation

baryluk
Copy link
Contributor

@baryluk baryluk commented Oct 24, 2022

Remove Provides in Debian package as this is incorrect usage of this flag.

To provide two versions of packages Conflicts as used is sufficient.

See Debian Policy Manual (v4.6.1.1) section 7.5

When at it Remove trailing dot in Description header to comply with section 5.6.13

Fixes: #1210

Remove Provides in Debian package as this is incorrect usage of this flag.

To provide two versions of packages `Conflicts` as used is sufficient.

See Debian Policy Manual (v4.6.1.1) section 7.5

When at it Remove trailing dot in Description header to comply with section 5.6.13
Fixes: #1210
@baryluk
Copy link
Contributor Author

baryluk commented Oct 24, 2022

@dandavison Please approve workflow.

@baryluk
Copy link
Contributor Author

baryluk commented Nov 6, 2022

Is there something stopping this PR being merged?

@dandavison
Copy link
Owner

Hi @baryluk, hm, yes, I don't personally know anything about Debian package formulas, and I had been hoping to get someone who did know about them to indicate approval -- I thought that would be good practice seeing as plenty of people are using this formula. So I had asked people in #504, but I guess no-one was up for it! Do you know someone else who can give an independent sign-off?

@jonassmedegaard
Copy link

Hi - Debian developer here - I can confirm that this proposed change is entirely sensible.

@dandavison
Copy link
Owner

Thanks @jonassmedegaard! And thanks @baryluk!

@dandavison dandavison merged commit b5ed58d into dandavison:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Cannot be installed with delta in Debian
3 participants