Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcehut link parsing #1190

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Add sourcehut link parsing #1190

merged 3 commits into from
Sep 14, 2022

Conversation

p00f
Copy link
Contributor

@p00f p00f commented Sep 14, 2022

No description provided.

@p00f
Copy link
Contributor Author

p00f commented Sep 14, 2022

You can try this out by cloning https://git.sr.ht/~p00f/godbolt.nvim and using git log - commit hashes are now clickable links which open the commit in a browser

@dandavison
Copy link
Owner

Hi @p00f - Nice, thanks!

(I think there's a typo in the name of the constant SOURHUT_REMOTE_URL Would you mind fixing that before we merge?)

@p00f
Copy link
Contributor Author

p00f commented Sep 14, 2022

Done

@p00f
Copy link
Contributor Author

p00f commented Sep 14, 2022

Do you mind me applying this fix for GitRemoteRepo too?
https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names

@dandavison
Copy link
Owner

Do you mind me applying this fix for GitRemoteRepo too?

Good call, please go ahead. (You could probably also change repo_slug to slug if you think that's better.)

@p00f
Copy link
Contributor Author

p00f commented Sep 14, 2022

Done

@p00f
Copy link
Contributor Author

p00f commented Sep 14, 2022

The readme mentions bitbucket but I can't find any bitbucket related code, should I change that to sourcehut too?

@dandavison
Copy link
Owner

The readme mentions bitbucket but I can't find any bitbucket related code, should I change that to sourcehut too?

Yes, thanks!

@p00f
Copy link
Contributor Author

p00f commented Sep 14, 2022

Done (CI passed before the readme change)

@dandavison dandavison merged commit d16ed23 into dandavison:master Sep 14, 2022
@dandavison
Copy link
Owner

Thanks very much @p00f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants