Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving from REQUIRE to Project.toml #76

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

nayyarv
Copy link
Contributor

@nayyarv nayyarv commented Jun 11, 2019

Hi Dan,

Sorry for the slow PR, I think I've gotten what needs to be done.
I've followed the instructions given here: https://github.com/JuliaRegistries/Registrator.jl in that I've moved the project to using a Project.toml instead of a REQUIRE file. I ran the tests and some custom code and nothing seems to have broken.

Once this is merged, you can comment on the commit with a @ JuliaRegistrator register and it should be good to go.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.382% when pulling 8f194bb on nayyarv:master into df7d400 on dancasimiro:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.382% when pulling 8f194bb on nayyarv:master into df7d400 on dancasimiro:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.382% when pulling 8f194bb on nayyarv:master into df7d400 on dancasimiro:master.

@dancasimiro
Copy link
Owner

Thanks @nayyarv. I’ll take a look today and get this merged.

@dancasimiro dancasimiro merged commit d57c410 into dancasimiro:master Jun 13, 2019
@dancasimiro
Copy link
Owner

dancasimiro commented Jun 13, 2019

@nayyarv I merged and notified the registrar. I already had a tag for v1.0.2, but I'm not sure if it needs to include this pull request. I already received an email though, so I am going to wait and see what happens.

@nayyarv
Copy link
Contributor Author

nayyarv commented Jun 14, 2019

I think it looks good on my side. Servers are getting the latest commit with the Project.toml, though you're right, the github tag is not correct anymore.

Maybe you should delete the existing 1.0.2 and retag the current release and rely on the Julia Tagbot going forward (that is, until the changes on you again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants