Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Julia v0.7? #66

Closed
rdeits opened this issue Aug 16, 2018 · 9 comments
Closed

Support Julia v0.7? #66

rdeits opened this issue Aug 16, 2018 · 9 comments
Labels

Comments

@rdeits
Copy link
Contributor

rdeits commented Aug 16, 2018

I don't think there are any released versions of WAV.jl that support Julia 0.7, which makes it harder to migrate any code that uses this package. The typical migration path is v0.6.4 -> v0.7 -> fix deprecations -> v1.0, but that's not possible if WAV.jl doesn't support v0.7.

Would you be willing to drop the required version to 0.7? I don't think there's any downside to doing so.

@dancasimiro
Copy link
Owner

Sorry, I messed this up rushing out a version that supports Julia v1.0. What are my options? Can I release WAV.jl v1.0.1 that claims to support Julia v0.7 and Julia v1.0? It's the same code so should be ok... However, I don't know the ins and outs of Pkg3.

@rdeits
Copy link
Contributor Author

rdeits commented Aug 17, 2018

Heh, that's a good question. I just posted over in #helpdesk on slack, so perhaps someone there knows. I'd suggest merging #68 regardless, since that will at least get CI working again.

@dancasimiro
Copy link
Owner

thanks @rdeits

#68 is merged; I had to resolve a minor conflict with a commit from Femto Cleaner.

@bjarthur
Copy link
Contributor

downgrading the requirements from 1.0 to 0.7 has been done before. can't remember the name of the packaged, but it was one that @quinnj takes care of IIRC.

@quinnj
Copy link

quinnj commented Oct 30, 2018

yeah, we originally made this mistake w/ Missings.jl, where the lower julia version was put as 1.0 instead of 0.7.

@dancasimiro
Copy link
Owner

I’ll try to take a look at the history of Missings.jl this weekend.

dancasimiro added a commit that referenced this issue Nov 4, 2018
This should have been done at the same time that 1.0 support was
pushed. Version 0.7 makes it easier for users to update to julia
1.0.

Fix issue #66
@bjarthur
Copy link
Contributor

i get this warning in julia 0.7:

WARNING: importing deprecated binding Base.Libdl into WAV.
WARNING: Base.Libdl is deprecated, run `using Libdl` instead
  likely near /Users/arthurb/.julia/packages/WAV/npPEy/src/WAV.jl:780

i think to support 0.7 the REQUIRES file simply needs to be changed, and any depwarns like the above fixed.

@bjarthur
Copy link
Contributor

ah, i see you've done this on master. might want to tag a release.

@dancasimiro
Copy link
Owner

@bjarthur I tagged v1.0.1 with this fix. See JuliaLang/METADATA.jl#20253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants