-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Julia v0.7? #66
Comments
Sorry, I messed this up rushing out a version that supports Julia v1.0. What are my options? Can I release WAV.jl v1.0.1 that claims to support Julia v0.7 and Julia v1.0? It's the same code so should be ok... However, I don't know the ins and outs of Pkg3. |
Heh, that's a good question. I just posted over in |
downgrading the requirements from 1.0 to 0.7 has been done before. can't remember the name of the packaged, but it was one that @quinnj takes care of IIRC. |
yeah, we originally made this mistake w/ Missings.jl, where the lower julia version was put as 1.0 instead of 0.7. |
I’ll try to take a look at the history of Missings.jl this weekend. |
This should have been done at the same time that 1.0 support was pushed. Version 0.7 makes it easier for users to update to julia 1.0. Fix issue #66
i get this warning in julia 0.7:
i think to support 0.7 the REQUIRES file simply needs to be changed, and any depwarns like the above fixed. |
ah, i see you've done this on master. might want to tag a release. |
@bjarthur I tagged v1.0.1 with this fix. See JuliaLang/METADATA.jl#20253 |
I don't think there are any released versions of WAV.jl that support Julia 0.7, which makes it harder to migrate any code that uses this package. The typical migration path is v0.6.4 -> v0.7 -> fix deprecations -> v1.0, but that's not possible if WAV.jl doesn't support v0.7.
Would you be willing to drop the required version to 0.7? I don't think there's any downside to doing so.
The text was updated successfully, but these errors were encountered: