-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to write multiple LIST chunks #55
Milestone
Comments
rjkat
added a commit
to rjkat/WAV.jl
that referenced
this issue
Apr 12, 2018
Fixed by pull request #56, but still waiting for documentation updates. |
Thanks Dan. I've updated the docs. Feel free to edit as you see fit 😄 |
Merged
I am going to wait for other breaking changes before publishing v1.0.0 of the WAV library. I would also like to wait until the FileIO.jl package is updated to support the newest Julia. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the current API it's not possible to write multiple chunks of the same type. This is needed e.g. for writing a .wav file that contains both a LIST chunk for the INFO chunk and another one for the cue points.
I propose that
wavwrite
be updated as follows:This would allow multiple LIST chunks to be written, and also allow the order of chunks written to be specified (at the moment it depends on Julia's hashing) but it will be a breaking change to the API. We'll have to change
wavread
as well - we can make it return aVector{Tuple{Symbol, Array{UInt8,1}}
or aDict{Symbol, Vector{Any}}
where the entries in the dictionary are vectors containing all the chunks with a particular ID. I'd tend to go with the first option because it means you could read/write chunks without having to convert between the two types.@dancasimiro if you approve of this change then I'm happy to implement and test it. If not, let me know your thoughts on other options.
The text was updated successfully, but these errors were encountered: