Package the license file #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the license file is packaged in `sdist`s, `whl`s, and other package formats.
Appears `setup.py` tries to read `README-PYPI.rst` and `CHANGELOGS.rst`, which are not in the `sdist`. This fixes that.
jakirkham
commented
May 2, 2018
| include README.rst | ||
| include README-PYPI.rst |
There was a problem hiding this comment.
Also appears these files are needed by setup.py and they are not included in the sdist currently. Added them here so we can get that fixed as well. Should note this is breaking the pip install of sdists by not having these files included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the license file is packaged in
sdists,whls, and other package formats.