Skip to content

Commit

Permalink
Specify props types properly
Browse files Browse the repository at this point in the history
  • Loading branch information
spider-hand committed Sep 12, 2022
1 parent 30a62df commit a7b4979
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 10 deletions.
8 changes: 4 additions & 4 deletions src/components/Game/ResultModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@

<script lang="ts">
/*global google*/
import { GameHistory } from "@/types";
import { defineComponent, watch, onMounted, ref } from "vue";
import { GameHistory, Summary, DistanceByPlayer } from "@/types";
import { defineComponent, watch, onMounted, ref, PropType } from "vue";
export default defineComponent({
props: {
Expand Down Expand Up @@ -150,7 +150,7 @@ export default defineComponent({
default: null,
},
distanceByPlayerArr: {
type: Array,
type: Array as PropType<DistanceByPlayer[]>,
required: true,
},
round: {
Expand All @@ -162,7 +162,7 @@ export default defineComponent({
required: true,
},
multiplayerGameSummary: {
type: Array,
type: Array as PropType<Summary[]>,
required: true,
},
},
Expand Down
6 changes: 3 additions & 3 deletions src/components/Home/CreateRoomDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export default defineComponent({
},
roomNumber: {
type: String,
required: false,
required: true,
},
isReadyForMultiplayerGame: {
type: Boolean,
Expand All @@ -153,8 +153,8 @@ export default defineComponent({
},
setup(props, context) {
const roomCannnotBeFoundError = computed<string | null>(() =>
!props.isRoomFound ? "The room cannot be found." : null
const roomCannnotBeFoundError = computed<string | undefined>(() =>
!props.isRoomFound ? "The room cannot be found." : undefined
);
const onChangeSize = (newVal: number): void => {
Expand Down
4 changes: 2 additions & 2 deletions src/components/Home/SelectBoxDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

<script lang="ts">
import { SelectboxOption } from "@/types";
import { defineComponent } from "vue";
import { defineComponent, PropType } from "vue";
export default defineComponent({
props: {
Expand All @@ -33,7 +33,7 @@ export default defineComponent({
required: true,
},
options: {
type: Array,
type: Array as PropType<SelectboxOption[]>,
required: true,
},
},
Expand Down
2 changes: 1 addition & 1 deletion src/store/modules/gameSettingsStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export interface GameSettingsState {
selectedMap: string;
selectedMode: string;
selectedSize: number;
selectedTime: number | null;
selectedTime: number;
playerName: string;
playerId: string;
isOwner: boolean;
Expand Down
5 changes: 5 additions & 0 deletions src/types/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,8 @@ export type Summary = {
playerName: string;
score: number;
};

export type DistanceByPlayer = {
playerName: string;
distance: number;
}

0 comments on commit a7b4979

Please sign in to comment.