Specify props types properly

damnUUUU · Sep 12, 2022 · a7b4979 · a7b4979
1 parent 30a62df
commit a7b4979
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 10 deletions.
diff --git a/src/components/Game/ResultModal.vue b/src/components/Game/ResultModal.vue
@@ -103,8 +103,8 @@
 
 <script lang="ts">
 /*global google*/
-import { GameHistory } from "@/types";
-import { defineComponent, watch, onMounted, ref } from "vue";
+import { GameHistory, Summary, DistanceByPlayer } from "@/types";
+import { defineComponent, watch, onMounted, ref, PropType } from "vue";
 
 export default defineComponent({
  props: {
@@ -150,7 +150,7 @@ export default defineComponent({
  default: null,
  },
  distanceByPlayerArr: {
- type: Array,
+ type: Array as PropType<DistanceByPlayer[]>,
  required: true,
  },
  round: {
@@ -162,7 +162,7 @@ export default defineComponent({
  required: true,
  },
  multiplayerGameSummary: {
- type: Array,
+ type: Array as PropType<Summary[]>,
  required: true,
  },
  },

diff --git a/src/components/Home/CreateRoomDialog.vue b/src/components/Home/CreateRoomDialog.vue
@@ -138,7 +138,7 @@ export default defineComponent({
  },
  roomNumber: {
  type: String,
- required: false,
+ required: true,
  },
  isReadyForMultiplayerGame: {
  type: Boolean,
@@ -153,8 +153,8 @@ export default defineComponent({
  },
 
  setup(props, context) {
- const roomCannnotBeFoundError = computed<string | null>(() =>
- !props.isRoomFound ? "The room cannot be found." : null
+ const roomCannnotBeFoundError = computed<string | undefined>(() =>
+ !props.isRoomFound ? "The room cannot be found." : undefined
  );
 
  const onChangeSize = (newVal: number): void => {

diff --git a/src/components/Home/SelectBoxDialog.vue b/src/components/Home/SelectBoxDialog.vue
@@ -23,7 +23,7 @@
 
 <script lang="ts">
 import { SelectboxOption } from "@/types";
-import { defineComponent } from "vue";
+import { defineComponent, PropType } from "vue";
 
 export default defineComponent({
  props: {
@@ -33,7 +33,7 @@ export default defineComponent({
  required: true,
  },
  options: {
- type: Array,
+ type: Array as PropType<SelectboxOption[]>,
  required: true,
  },
  },

diff --git a/src/store/modules/gameSettingsStore.ts b/src/store/modules/gameSettingsStore.ts
@@ -6,7 +6,7 @@ export interface GameSettingsState {
  selectedMap: string;
  selectedMode: string;
  selectedSize: number;
- selectedTime: number | null;
+ selectedTime: number;
  playerName: string;
  playerId: string;
  isOwner: boolean;

diff --git a/src/types/index.d.ts b/src/types/index.d.ts
@@ -12,3 +12,8 @@ export type Summary = {
  playerName: string;
  score: number;
 };
+
+export type DistanceByPlayer = {
+ playerName: string;
+ distance: number;
+}