Fix issue #1954: Ensure CheckingAuthFinished event fires regardless of authentication state #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ardless of authentication state
|
Any idea when this will be released? We will need to revert back down to v17 for now |
|
I will release tomorrow, will do some testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request addresses issue #1954 by ensuring that the
EventTypes.CheckingAuthFinishedevent is fired regardless of the authentication state.Problem
In commit 4143e2444330dc86ab3a59574f7511b461e75a61, the
fireEvent(EventTypes.CheckingAuthFinished)was moved inside theif (isAuthenticated)block. This change caused the event not to fire when the authentication state is false, which leads to the issue described in #1954.