Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

userHandle null #50

Closed
nicowitteman opened this issue Oct 29, 2022 · 2 comments
Closed

userHandle null #50

nicowitteman opened this issue Oct 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@nicowitteman
Copy link

In passwordless.login.js, in verifyAssertionWithServer, if assertedCredential.response.userHandle is null, still userHandle in data.response is set to "" by coerceToBase64Url(userHandle). Suggest to add check on userHandle.length like so:
userHandle: userHandle !== null && userHandle.length > 0 ? coerceToBase64Url(userHandle) : null,
@damienbod
Copy link
Owner

@nicowitteman Thanks for the feedback! Would you like to do a PR? If not I will update

Greetings Damien

@damienbod damienbod added the enhancement New feature or request label Oct 29, 2022
nicowitteman pushed a commit to nicowitteman/AspNetCoreIdentityFido2Mfa-1 that referenced this issue Mar 1, 2023
Check on userHandle null issue damienbod#50
181d3a6
@nicowitteman
Copy link
Author

I prepared a PR, waiting for merge of #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damienbod @nicowitteman