Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pipelining #65

Merged
merged 1 commit into from
Aug 14, 2020
Merged

fix pipelining #65

merged 1 commit into from
Aug 14, 2020

Conversation

jacekgry
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@plutasnyy plutasnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

God job!

Comment on lines +180 to +189
@pytest.mark.parametrize("encoding_strategy", ['dense', 'sparse', 'OVO', 'OVA', 'complete'])
@pytest.mark.parametrize("oversampling", [None, 'globalCS', 'SMOTE', 'SOUP'])
def test_ecoc_with_sklearn_pipeline(encoding_strategy, oversampling):
pipeline = Pipeline([
('scaler', StandardScaler()),
('ecoc', ecoc.ECOC(encoding=encoding_strategy, preprocessing=oversampling))
])
pipeline.fit(X, y)
y_hat = pipeline.predict(np.array([[1.1, 2.2, 3.3], [4.4, 5.5, 6.6], [7.7, 8.8, 9.9]]))
assert len(y_hat) == 3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@plutasnyy plutasnyy merged commit 37c3263 into develop Aug 14, 2020
@plutasnyy plutasnyy deleted the ecoc-ovo-fix-pipelining branch August 14, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants