Allow configuration of a self-hosted Plausible instance #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luizkowalski hey! Thanks a lot for your contribution! I will add some tests and publish it as soon as possible. In a RubyonRails app, you should put this code in an initiliazer, right? PlausibleApi.configure do |config|
config.base_url = "https://your-plausible-instance.com/"
end |
jnunemaker
reviewed
Feb 2, 2024
lib/plausible_api/configuration.rb
Outdated
| attr_accessor :base_url | ||
|
|
||
| def base_url | ||
| @base_url || "https://plausible.io" |
There was a problem hiding this comment.
What I often do is setup defaults in initialize and then do an attr_accessor as you have for overriding. Then you aren't making the same string over and over. Minor so every one feel free to ignore me.
There was a problem hiding this comment.
updated. let me know if that's what you meant.
@luctus as a rails user, yep! That's what we recommend for flipper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey 👋🏻
I've been playing around with self-hosting my Plausible instance and notice that the gem defaults to
plausible.ioI quickly put together an option to customize it but defaults to
plausible.io