Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: createPages type #656

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: createPages type #656

merged 1 commit into from
Apr 9, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Apr 8, 2024

we need to export js code not only types.

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Apr 8, 2024 2:07am

Copy link

codesandbox-ci bot commented Apr 8, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi marked this pull request as ready for review April 8, 2024 03:40
Copy link

@beefchimi beefchimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to solve the problem 👍

To test, I simply ran pnpm compile on this branch and manually copied the waku > dist, src, and cli.js folders/files into a test project. The createPages complaint has gone away 😄

The new main.d.ts looks like:

main

As an aside, I do appear to have an issue with compile for create-waku:

Terminal output

create

@dai-shi
Copy link
Owner Author

dai-shi commented Apr 9, 2024

@beefchimi Thanks for confirming!

To test

Actually, you can go to the codesandbox ci page,

image

click here ☝️ , and find "Local Install Instructions".

@dai-shi
Copy link
Owner Author

dai-shi commented Apr 9, 2024

As an aside, I do appear to have an issue with compile for create-waku

I'm not sure, but it looks like pnpm install didn't work well, or?

@dai-shi dai-shi merged commit 9bd59d6 into main Apr 9, 2024
28 checks passed
@dai-shi dai-shi deleted the fix/create-pages-type branch April 9, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants