Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-waku): recover choose option #647

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Apr 3, 2024

I had thought it would be nice to have a single --example option, but changed my mind. This introduces --choose option again.

#315 (reply in thread)

closes #625
along with #641

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Apr 3, 2024 1:01am

Copy link

codesandbox-ci bot commented Apr 3, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi marked this pull request as ready for review April 3, 2024 01:23
@ojj1123
Copy link
Contributor

ojj1123 commented Apr 3, 2024

but it comes with a hack DEFAULT_REF.
#315 (reply in thread)

I agree with you.
But I don't think it is necessary to use --choose option. Because even if we don't write --choose option, we can select the template by default. So, how about choosing one of the templates without --choose option?

I think it's easier to choose a template without --choose than to choose it with --choose.
Like this:

> pnpm create waku
✔ Project name: … waku-project
✔ Select a framework: › 
  > template-js
     template-ts
     tailwind-js
     tailwind-ts
     ...

Scaffolding project in /Users/jeongjin/GitHub/waku-project...

Above the example, We could select template-js by default.
create-next-app and create-vite use this way. Try it!

pnpm create vite
pnpm create next-app

@ojj1123
Copy link
Contributor

ojj1123 commented Apr 3, 2024

And --example option is just used to download the other repo?

@dai-shi
Copy link
Owner Author

dai-shi commented Apr 3, 2024

we can select the template by default.

We used to have it. It's intentional for now. This is an advanced option, because not all examples are well described.
Eventually, if we improve some templates so that we can recommend them, we can enable the selector again.

@dai-shi dai-shi merged commit e8ca9ac into main Apr 4, 2024
28 checks passed
@dai-shi dai-shi deleted the create-with-local-template branch April 4, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Optional Tools in Create Usage
2 participants