fix: double modules hazard by preferring relative paths #645
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -165,23 +165,21 @@ export const devServer: Middleware = (options) => { | |||
| vitePromise, | |||
| ]); | |||
|
|
|||
| if (!initialModules) { | |||
There was a problem hiding this comment.
yea just removed it because it was not needed, not any other reason. And it worked this way.
| const file = ( | ||
| filePath.slice(config.basePath.length).startsWith('@fs/') | ||
| ? filePath.slice((config.basePath + '@fs').length) | ||
| : filePath | ||
| ).split('?')[0]!; | ||
| const wakuDist = joinPath( | ||
| fileURLToFilePath(import.meta.url), | ||
| '../../..', | ||
| ); | ||
| if (file.startsWith(wakuDist)) { | ||
| const fileWithAbsolutePath = | ||
| !file.startsWith(opts.rootDir) && !file.startsWith(wakuDist) | ||
| ? encodeFilePathToAbsolute(joinPath(opts.rootDir, file)) | ||
| : file; | ||
| if ( | ||
| file.startsWith(wakuDist) || | ||
| fileWithAbsolutePath.startsWith(wakuDist) |
There was a problem hiding this comment.
This part looks a little bit complicated and has room for improvement.
There was a problem hiding this comment.
it makes /user/project/src/comp.tsx into /src/comp.tsx
There was a problem hiding this comment.
Yeah, but this entire block can be refactored for more readability, no?
There was a problem hiding this comment.
Hm, I think we can remove L279.
|
Everything's passing, congrats! |
close #631