Allow environment variables in dagster-mlflow schema
#7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chasleslr is attempting to deploy a commit to the Elementl Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
jamiedemaria
requested changes
May 25, 2022
python_modules/libraries/dagster-mlflow/dagster_mlflow/resources.py
Outdated
Show resolved
Hide resolved
jamiedemaria
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We would like to provide the
mlflow_tracking_uriandexperiment_nameconfiguration parameters as environment variables given that they often vary based on the deployment (i.e. staging vs. prod).How I Tested These Changes
I don't think a test is necessary here, but flag otherwise! I looked for examples in other dagster libraries of how
StringSourcemight be tested in this context but did not find any.