refactor: rename is_failure to is_failure_or_canceled #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). dagster – ./docs/next🔍 Inspect: https://vercel.com/elementl/dagster/FFi6fSpEYUXX13nH1ZU4qz47DKp6 [Deployment for 1e1f506 canceled] dagit-storybook – ./js_modules/dagit/packages/ui🔍 Inspect: https://vercel.com/elementl/dagit-storybook/92coDa4UnMNZMYUVxMTxwsxanX6V [Deployment for 1e1f506 canceled] |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alangenfeld
approved these changes
Mar 25, 2022
alangenfeld
reviewed
Mar 25, 2022
ec473c6
to
1e1f506
Compare
sryza
pushed a commit
that referenced
this pull request
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This could technically break people who are using our internal APIs? considering that this is returned in the results when executing in process.
.is_failureto.is_failure_or_canceled.is_failureto only check for failure statusTest Plan
existing bk