Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dagster-k8s): add run id label to run/step workers #7167

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

rexledesma
Copy link
Contributor

Summary

When debugging run workers, it would be nice to easily retrieve the job associated with a certain run id.

Now this should be possible with:

kubectl get pods -l dagster/run-id=XXX

Test Plan

integration
existing bk

@vercel
Copy link

vercel bot commented Mar 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dagster – ./docs/next

🔍 Inspect: https://vercel.com/elementl/dagster/6T3UF7xx7nJuHWS96KpcCRYGjiCJ
✅ Preview: Canceled

dagit-storybook – ./js_modules/dagit/packages/ui

🔍 Inspect: https://vercel.com/elementl/dagit-storybook/7pAVP5ECJchJ9RzLaKhxXomYBfr7
✅ Preview: Canceled

@vercel vercel bot temporarily deployed to Preview – dagster March 23, 2022 00:40 Inactive
@vercel vercel bot temporarily deployed to Preview – dagit-storybook March 23, 2022 00:40 Inactive
@rexledesma
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@rexledesma rexledesma requested a review from a team March 23, 2022 00:40
@rexledesma rexledesma self-assigned this Mar 23, 2022
Copy link
Member

@alangenfeld alangenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats up with the - vs _ stuff ? I forget the k8s rules/norms

Copy link
Member

@alangenfeld alangenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks in line with the other entries so i assume its fine

@rexledesma rexledesma merged commit 0c7f490 into master Mar 23, 2022
@rexledesma rexledesma deleted the rl/add-run-id-k8s-labels branch March 23, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants