Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(daemon): retrieve daemon heartbeats in batch #6843

Merged

Conversation

rexledesma
Copy link
Member

Summary

As the title. One call to retrieve all daemon heartbeats suffices to calculate daemon health.

Test Plan

existing pytest

@vercel
Copy link

vercel bot commented Mar 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dagit-storybook – ./js_modules/dagit/packages/ui

🔍 Inspect: https://vercel.com/elementl/dagit-storybook/3ai3xYLisZizTHpg1UTteJU4vgsL
✅ Preview: Canceled

[Deployment for 1d862ae canceled]

dagster – ./docs/next

🔍 Inspect: https://vercel.com/elementl/dagster/AHXUNpb8SqAvpmNbNjh8sk7uuk8U
✅ Preview: Canceled

[Deployment for 1d862ae canceled]

@rexledesma
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@vercel vercel bot temporarily deployed to Preview – dagit-storybook March 1, 2022 01:42 Inactive
@vercel vercel bot temporarily deployed to Preview – dagster March 1, 2022 01:42 Inactive
@rexledesma rexledesma force-pushed the rex/plat-1049-refactor-get_daemon_status-to-retrieve branch from 00a0135 to 04aae51 Compare March 1, 2022 02:21
@vercel vercel bot temporarily deployed to Preview – dagster March 1, 2022 02:21 Inactive
@vercel vercel bot temporarily deployed to Preview – dagit-storybook March 1, 2022 02:21 Inactive
@rexledesma rexledesma force-pushed the rex/plat-1049-refactor-get_daemon_status-to-retrieve branch from 04aae51 to 1d862ae Compare March 1, 2022 02:31
@vercel vercel bot temporarily deployed to Preview – dagit-storybook March 1, 2022 02:31 Inactive
@vercel vercel bot temporarily deployed to Preview – dagster March 1, 2022 02:31 Inactive
@rexledesma rexledesma requested review from gibsondan, johannkm and a team March 1, 2022 02:32
@rexledesma rexledesma self-assigned this Mar 1, 2022
@rexledesma rexledesma merged commit d98aa5c into master Mar 1, 2022
@rexledesma rexledesma deleted the rex/plat-1049-refactor-get_daemon_status-to-retrieve branch March 1, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants