Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(helm): update chart metadata #6778

Merged
merged 1 commit into from
Feb 23, 2022
Merged

docs(helm): update chart metadata #6778

merged 1 commit into from
Feb 23, 2022

Conversation

rexledesma
Copy link
Contributor

Summary

  • update maintainers to Elementl
  • use updated Dagster icon

Test Plan

N/A

@rexledesma
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@vercel
Copy link

vercel bot commented Feb 23, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

dagit-storybook – ./js_modules/dagit/packages/ui

🔍 Inspect: https://vercel.com/elementl/dagit-storybook/BuAq1RFx722Pu9hVL5YD6GqjRnMG
✅ Preview: Canceled

dagster – ./docs/next

🔍 Inspect: https://vercel.com/elementl/dagster/4ctbBAqmu3aZatA8geVsmKMmfi9o
✅ Preview: Canceled

@vercel vercel bot temporarily deployed to Preview – dagit-storybook February 23, 2022 23:03 Inactive
@vercel vercel bot temporarily deployed to Preview – dagster February 23, 2022 23:03 Inactive
@rexledesma rexledesma requested review from johannkm and a team February 23, 2022 23:03
@rexledesma rexledesma self-assigned this Feb 23, 2022
jmsanders
jmsanders approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@jmsanders jmsanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

helm/dagster/Chart.yaml
url: https://dagster.io
icon: https://dagster.io/images/logo.png
- name: Elementl
email: [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a real email address?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And even if it is, do we want to perhaps have a [email protected] too/instead?

Copy link
Contributor Author

@rexledesma rexledesma Feb 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a real email address. it was easy to create this since we own the google workspace domain. Not sure about making an dagster.io one though. I'll stick to Elementl

helm/dagster/Chart.yaml
icon: https://dagster.io/images/logo.png
- name: Elementl
email: [email protected]
url: https://elementl.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elementl.com or dagster.io?

@rexledesma rexledesma merged commit 2b6ded6 into master Feb 23, 2022
@rexledesma rexledesma deleted the rl/update-chart-metadata branch February 23, 2022 23:25
sryza pushed a commit that referenced this pull request Feb 24, 2022
@rexledesma @sryza
docs(helm): update chart metadata (#6778)
d16d781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmsanders jmsanders jmsanders approved these changes

@johannkm johannkm Awaiting requested review from johannkm

Assignees

@rexledesma rexledesma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rexledesma @jmsanders