Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): update Chart.yaml to reflect dev version #5351

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

rexledesma
Copy link
Contributor

Summary

When developing on main, accurately reflect the fact that the chart is in a development version.
In the packaged chart, the version updated to reflect the actual release version.

Test Plan

integration

@vercel
Copy link

vercel bot commented Oct 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/elementl/dagster/Hz75ZUZLsA2JGYuUofhfcMTnAfPA
✅ Preview: https://dagster-git-rl-helm-chart-version-elementl.vercel.app

[Deployment for 871a474 canceled]

@rexledesma
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite and will continue to be automatically updated while this PR remains open.

Copy link
Member

@gibsondan gibsondan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@@ -1,7 +1,7 @@
dependencies:
- name: dagster-user-deployments
repository: ""
version: 0.11.3
version: 0.0.1-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there benefit to having it be 0.0.1-dev as opposed to 'dev'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is validated against SemVer, which requires that a version number be specified.

@rexledesma rexledesma merged commit 1526964 into master Oct 26, 2021
@rexledesma rexledesma deleted the rl/helm-chart-version branch October 26, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants