revert single implicit asset job #23607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ccdb63c.
|
Faster fix here: #23623 |
clairelin135
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Summary & Motivation It turns out this breaks some functionality in the launch modal. Working with @bengotow to fix that functionality, but I don't think it will land in time for this week's release. ## How I Tested These Changes
PedramNavid
pushed a commit
that referenced
this pull request
Aug 14, 2024
## Summary & Motivation It turns out this breaks some functionality in the launch modal. Working with @bengotow to fix that functionality, but I don't think it will land in time for this week's release. ## How I Tested These Changes
sryza
added a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 35f00aa. ## Summary & Motivation We had reverted the single implicit asset job stack after discovering that it caused problems in the UI. Those problems are fixed by the stack ending in [this GraphQL change](#23494) and [this frontend change](#23747). So this unreverts. It shouldn't be merged until that frontend change makes it in. ## How I Tested These Changes
jmsanders
pushed a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 35f00aa. ## Summary & Motivation We had reverted the single implicit asset job stack after discovering that it caused problems in the UI. Those problems are fixed by the stack ending in [this GraphQL change](#23494) and [this frontend change](#23747). So this unreverts. It shouldn't be merged until that frontend change makes it in. ## How I Tested These Changes (cherry picked from commit 2616f6d)
cmpadden
pushed a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 35f00aa. ## Summary & Motivation We had reverted the single implicit asset job stack after discovering that it caused problems in the UI. Those problems are fixed by the stack ending in [this GraphQL change](#23494) and [this frontend change](#23747). So this unreverts. It shouldn't be merged until that frontend change makes it in. ## How I Tested These Changes
jmsanders
added a commit
that referenced
this pull request
Aug 21, 2024
jmsanders
pushed a commit
that referenced
this pull request
Aug 22, 2024
This reverts commit 35f00aa. ## Summary & Motivation We had reverted the single implicit asset job stack after discovering that it caused problems in the UI. Those problems are fixed by the stack ending in [this GraphQL change](#23494) and [this frontend change](#23747). So this unreverts. It shouldn't be merged until that frontend change makes it in. ## How I Tested These Changes (cherry picked from commit 2616f6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
It turns out this breaks some functionality in the launch modal. Working with @bengotow to fix that functionality, but I don't think it will land in time for this week's release.
How I Tested These Changes