Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "switch get_event_records => fetch_materializations for multi asset sensors (#22779)" #23226

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Revert "switch get_event_records => fetch_materializations for multi asset sensors (#22779)" #23226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions python_modules/dagster/dagster/_core/definitions/multi_asset_sensor_definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,8 @@ def get_asset_cursor_with_advances(
context: MultiAssetSensorEvaluationContext,
initial_cursor: MultiAssetSensorContextCursor,
) -> MultiAssetSensorAssetCursorComponent:
from dagster._core.event_api import AssetRecordsFilter
from dagster._core.events import DagsterEventType
from dagster._core.storage.event_log.base import EventRecordsFilter

advanced_records: Set[int] = self._advanced_record_ids_by_key.get(asset_key, set())
if len(advanced_records) == 0:
Expand All @@ -893,25 +894,20 @@ def get_asset_cursor_with_advances(
latest_unconsumed_record_by_partition = (
initial_asset_cursor.trailing_unconsumed_partitioned_event_ids
)
limit = greatest_consumed_event_id_in_tick - (
latest_consumed_event_id_at_tick_start or 0
)
materializations_events = (
context.instance.fetch_materializations(
AssetRecordsFilter(
unconsumed_events = list(context.get_trailing_unconsumed_events(asset_key)) + list(
context.instance.get_event_records(
EventRecordsFilter(
event_type=DagsterEventType.ASSET_MATERIALIZATION,
asset_key=asset_key,
after_storage_id=latest_consumed_event_id_at_tick_start,
before_storage_id=greatest_consumed_event_id_in_tick,
after_cursor=latest_consumed_event_id_at_tick_start,
before_cursor=greatest_consumed_event_id_in_tick,
),
ascending=True,
limit=limit,
).records
if limit > 0
)
if greatest_consumed_event_id_in_tick
> (latest_consumed_event_id_at_tick_start or 0)
else []
)
unconsumed_events = list(context.get_trailing_unconsumed_events(asset_key)) + list(
materializations_events
)

# Iterate through events in ascending order, storing the latest unconsumed
# event for each partition. If an advanced event exists for a partition, clear
Expand Down