[record] IHaveNew.__new__ Self return typehint #23213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
9be9ca4
to
e4fea93
Compare
|
I am guessing that we don't get this error due to some pyright setting we have on that isn't default? not sure |
OwenKephart
approved these changes
Jul 24, 2024
jamiedemaria
approved these changes
Jul 25, 2024
smackesey
pushed a commit
that referenced
this pull request
Jul 25, 2024
it appears that when installed, `@record_custom` + `IHaveNew` is assuming `__new__` returns `None` instead of `Unknown` causing it to believe `x` is `None` for `x = RunRecord()` explicitly tag `__new__`'s return to `Self` to resolve resolves #23214 ## How I Tested These Changes manually made the change in `site-packages` of installed copy of `1.7.13`
hellendag
pushed a commit
that referenced
this pull request
Jul 25, 2024
it appears that when installed, `@record_custom` + `IHaveNew` is assuming `__new__` returns `None` instead of `Unknown` causing it to believe `x` is `None` for `x = RunRecord()` explicitly tag `__new__`'s return to `Self` to resolve resolves #23214 ## How I Tested These Changes manually made the change in `site-packages` of installed copy of `1.7.13`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it appears that when installed,
@record_custom+IHaveNewis assuming__new__returnsNoneinstead ofUnknowncausing it to believexisNoneforx = RunRecord()explicitly tag
__new__'s return toSelfto resolveresolves #23214
How I Tested These Changes
manually made the change in
site-packagesof installed copy of1.7.13