[embedded-elt][dlt] align translator options with dagster-looker; refactor to builder method #23187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor asset specs to builder method
rexledesma
suggested changes
Jul 23, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/dlt/asset_decorator.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/dlt/asset_decorator.py
Show resolved
Hide resolved
...ules/libraries/dagster-embedded-elt/dagster_embedded_elt_tests/dlt_tests/test_asset_specs.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/dlt/asset_decorator.py
Show resolved
Hide resolved
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/dlt/asset_decorator.py
Outdated
Show resolved
Hide resolved
…_elt/dlt/asset_decorator.py Co-authored-by: Rex Ledesma <[email protected]>
…_elt/dlt/asset_decorator.py Co-authored-by: Rex Ledesma <[email protected]>
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-hxqtoakej-elementl.vercel.app Direct link to changed pages: |
rexledesma
approved these changes
Jul 24, 2024
python_modules/libraries/dagster-embedded-elt/dagster_embedded_elt/dlt/asset_decorator.py
Outdated
Show resolved
Hide resolved
…_elt/dlt/asset_decorator.py Co-authored-by: Rex Ledesma <[email protected]>
sryza
pushed a commit
that referenced
this pull request
Jul 24, 2024
…actor to builder method (#23187) ## Summary & Motivation A community member was requesting that we have an option to update tags for dlt assets -- this introduces translator options to align with `dagster-looker`. It is understood that we will move to some form of `AssetSpec` manipulation moving forward (see: [comment](https://github.com/dagster-io/dagster/pull/21845/files#r1600622279)). - Separates AssetSpec generation to `build_dlt_asset_specs` method for easier testing - Introduces translator options to be up-to-date with `dagster-looker` ## How I Tested These Changes `tox` --------- Co-authored-by: Rex Ledesma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
A community member was requesting that we have an option to update tags for dlt assets -- this introduces translator options to align with
dagster-looker. It is understood that we will move to some form ofAssetSpecmanipulation moving forward (see: comment).build_dlt_asset_specsmethod for easier testingdagster-lookerHow I Tested These Changes
tox